chore(announcements): simplify changes in supported envs #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change for consistency and readability
|
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
|
@MaxTru I'll take a look at this for you 👍 |
mesellings
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Hi @MaxTru, looks good, I made some edits as follows:
- Changed to Amazon OpenSearch rather than AWS (this is how we refer to it in the docs)
- Added a sentence under the heading - ideally, we should always have a sentence underneath headings.
- Front-loaded the content - i.e. put the important information at the front (e.g. changed "Raised minimum OpenJDK version..." to "OpenJDK minimum version raised" ) - helps when people scan pages for info relevant to them.
If you're happy with these changes, let me know and I'll approve the PR 👍
|
Great @mesellings ! The changes make a ton of sense and really improve this section. Thank you. Let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When should this change go live?
holdlabel or convert to draft PR)PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).